jbertram commented on PR #4899:
URL: 
https://github.com/apache/activemq-artemis/pull/4899#issuecomment-2302231138

   > No, `MessageFlowRecordImpl` becoming bad means that the peer broker holds 
on to an instance of it which should have been discarded.
   
   As far as I can tell the `AMQ222139` message is a direct symptom of the 
problem you describe. I don't think that message would occur if the broker 
wasn't holding an instance of `MessageFlowRecordImpl` which should have been 
discarded. Therefore, I think we're talking about the same essential problem.
   
   > We were already running that earlier. That resulted in other bugs with the 
topology.
   
   If that's the case then I think that is the bug we should be attempting to 
fix. For your particular use-case I think you should definitely be using `0` 
for `reconnect-attempts`.
   
   > We don't want to go back to a tried configuration which we know didn't 
work.
   
   Your current configuration with `reconnect-attempts` > `0` _also_ doesn't 
work so I'm not clear what the difference here. If neither configuration works 
then you should use the configuration which is actually appropriate for your 
use-case and fix whatever bugs (if any) exist for that configuration rather 
than fixing a bug for a configuration that isn't recommended.
   
   As it stands, the recommended configuration fixes the problem with the 
test-case in this PR so this fix is not valid and won't be merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to