clebertsuconic commented on code in PR #5216: URL: https://github.com/apache/activemq-artemis/pull/5216#discussion_r1745809155
########## artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPStandardMessage.java: ########## @@ -235,10 +239,87 @@ public void reloadPersistence(ActiveMQBuffer record, CoreMessageObjectPools pool // Message state is now that the underlying buffer is loaded, but the contents not yet scanned resetMessageData(); + recoverHeaderDataFromEncoding(); + modified = false; messageDataScanned = MessageDataScanningStatus.RELOAD_PERSISTENCE.code; } + private void recoverHeaderDataFromEncoding() { + final DecoderImpl decoder = TLSEncode.getDecoder(); + decoder.setBuffer(data); Review Comment: I mean.. I remember we would parse the header in out of order scenarios.. and we even had code.. I'm just wondering why you needed to add new code for that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact