cshannon commented on PR #1360: URL: https://github.com/apache/activemq/pull/1360#issuecomment-2523855943
> That's a good suggestion, I've added more parameters to the unit tests. I tried verifying the parameters are in effect but it's a little difficult without exposing the `protected` `Socket` on the `TcpTransport`. I tried researching a bunch of libraries that might check the TLS version on a TCP capture but it didn't really work and would also have introduced an extra dependency. Do you have any suggestions on a better approach for verifying the socket changes? A lot of the logic resides in the JVM so it's difficult to verify. Yeah, I wasn't sure if it would be possible to easily verify for that reason. You could try and use reflection to get access to the private/protected socket and make it accessible. I can also take a look next week as well...if it's not really possible that's ok but it would certainly be nice if we could do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
