jbertram commented on code in PR #5386:
URL: https://github.com/apache/activemq-artemis/pull/5386#discussion_r1876084441
##########
pom.xml:
##########
@@ -79,8 +79,8 @@
<properties>
<maven.compiler.source>11</maven.compiler.source>
- <maven.compiler.target>11</maven.compiler.target>
- <maven.compiler.release>11</maven.compiler.release>
+ <maven.compiler.target>17</maven.compiler.target>
+ <maven.compiler.release>17</maven.compiler.release>
Review Comment:
I left the source at 11 to facilitate back-porting fixes if necessary. Java
17 only has 2 language-level changes (i.e. sealed classes & pattern matching
for switch expressions and statements) which I don't think we'll adopt anytime
soon, but I think it makes sense to have a formal guard in place just to be
safe. We can move the source to 17 in 3.0 (assuming we drop support for 2.x at
that point). This is the same approach as taken [by
Classic](https://github.com/apache/activemq/blob/52a9aec22ec8309312cdd1a223f2f61dfbc83b2f/pom.xml#L117-118).
##########
docs/user-manual/versions.adoc:
##########
@@ -12,6 +12,26 @@ NOTE: If the upgrade spans multiple versions then the steps
from *each* version
NOTE: Follow the general upgrade procedure outlined in the
xref:upgrading.adoc#upgrading-the-broker[Upgrading the Broker] chapter in
addition to any version-specific upgrade instructions outlined here.
+== 2.39.0
+
+https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12355167[Full
release notes]
+
+=== Highlights
+
+* *Java 17 is now required.*
+
+=== Upgrading from 2.38.0
+
+* Due to https://issues.apache.org/jira/browse/ARTEMIS-5202[ARTEMIS-5202]
*support for Java 11 has been dropped*.
++
+The main reason for this change is that the version of Jetty we were embedding
in previous versions (i.e. 10)
https://github.com/jetty/jetty.project/issues/10485[will officially reach its
end-of-life on January 1, 2025] and will therefore no longer be receiving _any_
fixes - including security fixes.
+Security is critical for us and most of our users so we therefore need to
upgrade to Jetty 12 - the only version of Jetty now supported.
+Jetty 12 requires Java 17 so the difficult decision was made to drop support
for Java 11.
++
+Java 11 is quite old at this point and some vendors have already dropped
support for it so many (if not most) users have already upgraded to Java 17.
For those that haven't we apologize for any inconvenience.
Review Comment:
That's fair. Will fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
