gemmellr commented on code in PR #5394:
URL: https://github.com/apache/activemq-artemis/pull/5394#discussion_r1880563231
##########
pom.xml:
##########
@@ -107,7 +107,7 @@
<guava.version>33.3.1-jre</guava.version>
<hawtio.version>2.17.7</hawtio.version>
<jsr305.version>3.0.2</jsr305.version>
- <jetty.version>10.0.24</jetty.version>
+ <jetty.version>12.0.15</jetty.version>
Review Comment:
12.0.16 is out, worth updating now?
##########
artemis-pom/pom.xml:
##########
@@ -518,13 +518,31 @@
<!-- ## Jetty web Dependencies ##-->
<dependency>
- <groupId>org.eclipse.jetty</groupId>
- <artifactId>jetty-bom</artifactId>
+ <groupId>org.eclipse.jetty.ee8</groupId>
+ <artifactId>jetty-ee8-bom</artifactId>
Review Comment:
Why switch this rather than add the ee8 bom import in addition to the
existing one, they appear to be additive? If leaving the existing bom import,
the 3 new additions below shouldnt be needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
