gemmellr commented on code in PR #5407: URL: https://github.com/apache/activemq-artemis/pull/5407#discussion_r1892061469
########## tests/security-resources/build.sh: ########## @@ -175,6 +175,9 @@ openssl pkcs12 -in client-keystore.p12 -out client-key-cert.pem -nodes -password keytool -storetype pkcs12 -keystore server-ca-keystore.p12 -storepass $STORE_PASS -alias server-ca -exportcert -rfc > server-ca-cert.pem keytool -storetype pkcs12 -keystore client-ca-keystore.p12 -storepass $STORE_PASS -alias client-ca -exportcert -rfc > client-ca-cert.pem +## Combined ca-certs pem to verify loading of multiple certs +cat client-ca-cert.pem server-ca-cert.pem > client-and-server-ca-cert.pem Review Comment: Nitpick but can it be named client-and-server-ca-cert**s**.pem to make clearer later that its not a single shared cert. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
