brusdev commented on code in PR #5467:
URL: https://github.com/apache/activemq-artemis/pull/5467#discussion_r1934326840
##########
tests/e2e-tests/src/main/resources/containerService/artemis:
##########
@@ -44,7 +44,7 @@ if [ -z "$ARTEMIS_INSTANCE" ] ; then
ARTEMIS_INSTANCE=`cd "$ARTEMIS_INSTANCE/.." && pwd`
fi
-HAWTIO_ROLE="NO_HAWTIO_ROLE"
+HAWTIO_ROLES="NO_HAWTIO_ROLE"
Review Comment:
Should we also align the value?
```suggestion
HAWTIO_ROLES="NO_HAWTIO_ROLES"
```
##########
tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/console/ArtemisTest.java:
##########
@@ -14,29 +14,17 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-var Artemis;
-(function (Artemis) {
+package org.apache.activemq.artemis.tests.smoke.console;
- Artemis._module.factory('artemisMessage', function () {
- return { 'message': null };
- })
- .factory('artemisConnection', function () {
- return { 'connection': null };
- })
- .factory('artemisSession', function () {
- return { 'session': null };
- })
- .factory('artemisConsumer', function () {
- return { 'consumer': null };
- })
- .factory('artemisProducer', function () {
- return { 'producer': null };
- })
- .factory('artemisQueue', function () {
- return { 'queue': null };
- })
- .factory('artemisAddress', function () {
- return { 'address': null };
- });
+import org.apache.activemq.artemis.tests.smoke.console.ConsoleTest;
-})(Artemis || (Artemis = {}));
\ No newline at end of file
+public abstract class ArtemisTest extends ConsoleTest {
+ public ArtemisTest(String browser) {
+ super(browser);
+ }
+
+
+ public void loadLandingPage() {
Review Comment:
could the `loadLandingPage` method be moved to ConsoleTest class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
