AntonRoskvist commented on code in PR #5557:
URL: https://github.com/apache/activemq-artemis/pull/5557#discussion_r1995062569


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/config/PersistedBridgeConfiguration.java:
##########
@@ -62,7 +62,7 @@ public void decode(ActiveMQBuffer buffer) {
    }
 
    public String getName() {
-      return bridgeConfiguration.getParentName();
+      return bridgeConfiguration.getName();

Review Comment:
   @clebertsuconic It's not strictly necessary, but without it each 
configuration reload will log WARN messages (AMQ222124).
   
   I'll go ahead and change it so that the 
`ActiveMQServerImpl#recoverStoredBridges()` fetches this value from the 
underlying bridgeConfig instead and leave the `PersistedBridgeConfiguration` as 
it was.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to