cshannon commented on PR #1410:
URL: https://github.com/apache/activemq/pull/1410#issuecomment-2732980057
> Once a wrong named queue is created the broker is broken and not
restartable any more.
Ah ok, that was the part I was missing. So one thing to keep in mind when
creating a Jira or a PR is the more details for the motivation to help explain
why the change is necessary, the better. The jira only makes mention of the
exception when trying to make the consumer which makes a lot of sense.
I still do not see a reason to make any change here and things are working
as intended because:
1. The main point I was trying to make is creating a consumer or a producer
that matches the configured VT prefix and suffix, but is missing the actual
topic name, is a mistake and just continuing on without any error and allowing
the client to dynamically create that destination doesn't make any sense and
should be blocked. We shouldn't just hide the issue and allow things to carry
on.
2. The broker itself will also block you from creating a destination like
this if it is wrong. If the VirtualTopicInterceptor is created and the broker
config tries to create a destination like this it will break on start up and
should not create it. It would also break if trying to create it with JMX or
some other means so we prevent mistakes there which is good.
3. The only issue seems to be the edge case when the destination was created
by mistake somehow, probably before the interceptor was configured which would
mean the broker would no longer start up. While this is a problem obviously, in
that case it's a pretty easy fix and there is no risk of data loss. All you
need to do is disable the VirtualDestinationInterceptor configuration in the
broker config and then the broker would start up fine and you could delete the
bad destination before reconfiguring the interceptor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
