jeanouii commented on code in PR #1420:
URL: https://github.com/apache/activemq/pull/1420#discussion_r2043124913
##########
activemq-ra/src/main/java/org/apache/activemq/ra/ServerSessionImpl.java:
##########
@@ -64,8 +65,8 @@ public class ServerSessionImpl implements ServerSession,
InboundContext, Work, D
private MessageProducer messageProducer;
private final ServerSessionPoolImpl pool;
- private Object runControlMutex = new Object();
- private boolean runningFlag;
Review Comment:
So the trick can happen when there is no more session in the pool, then
ActiveMQ pulls an active session leading to a deadlock as I have observed. With
the AtomicInterger, the integrity is preserved without any locks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
