gemmellr commented on code in PR #5683:
URL: https://github.com/apache/activemq-artemis/pull/5683#discussion_r2095555488
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/bridge/AMQPBridgeConfiguration.java:
##########
@@ -314,4 +320,46 @@ public long getLinkRecoveryDelay() {
return DEFAULT_LINK_RECOVERY_DELAY;
}
}
+
+ /**
+ * {@return <code>true</code> if bridge is configured to auto delete
address senders that durable subscription bindings}
+ */
+ public boolean isAutoDeleteDurableSubscriptions() {
+ final Object property = properties.get(AUTO_DELETE_DURABLE_SUBSCRIPTION);
+ if (property instanceof Boolean) {
+ return (Boolean) property;
+ } else if (property instanceof String) {
+ return Boolean.parseBoolean((String) property);
+ } else {
+ return DEFAULT_AUTO_DELETE_DURABLE_SUBSCRIPTION;
+ }
+ }
+
+ /**
+ * {@return the auto delete subscription message count for address senders
using durable bindings}
+ */
+ public long getAutoDeleteDuableSubscriptionMsgCount() {
Review Comment:
```suggestion
public long getAutoDeleteDurableSubscriptionMsgCount() {
```
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/bridge/AMQPBridgeConfiguration.java:
##########
@@ -314,4 +320,46 @@ public long getLinkRecoveryDelay() {
return DEFAULT_LINK_RECOVERY_DELAY;
}
}
+
+ /**
+ * {@return <code>true</code> if bridge is configured to auto delete
address senders that durable subscription bindings}
+ */
+ public boolean isAutoDeleteDurableSubscriptions() {
+ final Object property = properties.get(AUTO_DELETE_DURABLE_SUBSCRIPTION);
+ if (property instanceof Boolean) {
+ return (Boolean) property;
+ } else if (property instanceof String) {
+ return Boolean.parseBoolean((String) property);
+ } else {
+ return DEFAULT_AUTO_DELETE_DURABLE_SUBSCRIPTION;
+ }
+ }
+
+ /**
+ * {@return the auto delete subscription message count for address senders
using durable bindings}
+ */
+ public long getAutoDeleteDuableSubscriptionMsgCount() {
+ final Object property =
properties.get(AUTO_DELETE_DURABLE_SUBSCRIPTION_MSG_COUNT);
+ if (property instanceof Number) {
+ return ((Number) property).intValue();
+ } else if (property instanceof String) {
+ return Integer.parseInt((String) property);
+ } else {
+ return DEFAULT_AUTO_DELETE_DURABLE_SUBSCRIPTION_MSG_COUNT;
+ }
+ }
+
+ /**
+ * {@return the auto delete subscription delay for address senders using
durable bindings}
+ */
+ public long getAutoDeleteDuableSubscriptionDelay() {
Review Comment:
```suggestion
public long getAutoDeleteDurableSubscriptionDelay() {
```
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/bridge/AMQPBridgeConfiguration.java:
##########
@@ -314,4 +320,46 @@ public long getLinkRecoveryDelay() {
return DEFAULT_LINK_RECOVERY_DELAY;
}
}
+
+ /**
+ * {@return <code>true</code> if bridge is configured to auto delete
address senders that durable subscription bindings}
Review Comment:
```suggestion
* {@return <code>true</code> if bridge is configured to auto delete
address senders using durable subscription bindings}
```
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/bridge/AMQPBridgeSenderConfiguration.java:
##########
@@ -30,4 +33,46 @@ public final class AMQPBridgeSenderConfiguration extends
AMQPBridgeLinkConfigura
public AMQPBridgeSenderConfiguration(AMQPBridgeConfiguration configuration,
Map<String, ?> properties) {
super(configuration, properties);
}
+
Review Comment:
Same comments as the parent config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
