tabish121 commented on PR #5739: URL: https://github.com/apache/activemq-artemis/pull/5739#issuecomment-2946145085
> This is currently a draft because the solution (a lock around a `synchronized` block) seems a bit cumbersome. I'm curious about others' thoughts. > > As with many dead-locks, there is not a test for this. The fix relies on static analysis. I'm wondering if it would be enough to just follow the change you made a bit further and use the ReentrantLock in place of the synchronized (this) bits to avoid the race as you've done by allowing the handle method to never run when the others are holding the lock and waiting on access to the Queue resources. I haven't wrapped my head around this code fully but that seems like it could lead to a simpler setup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
