cshannon commented on code in PR #1445:
URL: https://github.com/apache/activemq/pull/1445#discussion_r2130748267
##########
activemq-client/src/main/java/org/apache/activemq/filter/XPathExpression.java:
##########
@@ -120,15 +121,13 @@ protected static void
setupFeatures(DocumentBuilderFactory factory) {
}
}
}
- if (features.size() > 0) {
- StringBuilder featureString = new StringBuilder();
+ StringJoiner featureString = new StringJoiner(", ");
Review Comment:
You could move this inside the if statement so we are not constructing a new
StringJoiner unless we need it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
