tabish121 commented on code in PR #5793:
URL: https://github.com/apache/activemq-artemis/pull/5793#discussion_r2166663498
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/bridge/AMQPBridgeConstants.java:
##########
@@ -135,6 +135,25 @@ public final class AMQPBridgeConstants {
*/
public static final boolean DEFAULT_DISABLE_RECEIVER_DEMAND_TRACKING =
false;
+ /**
+ * Configuration property that controls if a bridge from address receiver
that has been configured
+ * to use durable subscriptions will prefer to use a shared durable
subscription if the remote peer
+ * indicates in its connection capabilities that it supports them. Using a
shared subscription can
+ * avoid a rare edge case race on rapid attach and re-attach cycles due to
demand coming and going
+ * rapidly which leads to a stuck consumer. Enabling this on configurations
that previously did not
+ * have this option or had it disabled could lead to orphaning a previous
subscription so care should
+ * be taken when enabling this option.
+ */
+ public static final String PREFER_SHARED_DURABLE_SUBSCRIPTIONS =
"preferSharedDurableSubscriptions";
+
+ /**
+ * Default value for whether a bridge from address receiver that has been
told to use durable subscriptions
+ * should prefer to use a shared durable address subscriptions or a
standard JMS style non-shared durable
+ * subscription. We default to false to ensure that older installations
that upgrade don't suddenly leave
+ * orphaned subscriptions from previous bridge address receivers.
+ */
+ public static final boolean DEFAULT_PREFER_SHARED_DURABLE_SUBSCRIPTIONS =
false;
Review Comment:
Updated the default to true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
