gemmellr commented on code in PR #5810:
URL: https://github.com/apache/activemq-artemis/pull/5810#discussion_r2180468245
##########
tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/upgradeTest/CompareUpgradeTest.java:
##########
@@ -69,7 +69,7 @@ public void testCompareWindowsFreshInstance() throws
Exception {
String windowsExpectedETC = basedir +
"/target/classes/servers/windowsUpgradeETCExpected";
compareDirectories(true, windowsExpectedBin, windowsBin);
- compareDirectories(true, windowsExpectedETC, windowsETC, "broker.xml",
"artemis-users.properties", "management.xml");
+ compareDirectories(true, windowsExpectedETC, windowsETC, "broker.xml",
"artemis-users.properties", "management.xml", "jolokia-access.xml");
Review Comment:
I think it would probably be better to add the new comment to the 'expected'
jolokia-access.xml so that the comparison to the new file doesnt actually fail.
That way, if some other changes occur to the file in future, the test will fail
to prompt a 'do we need to fix the upgrader to handle this' consideration
again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
