thompson-tomo commented on PR #92: URL: https://github.com/apache/activemq-nms-amqp/pull/92#issuecomment-3041393708
@Havret I am sorry but you missed the point, System.Threading.Tasks.Dataflow is natively included in the newer dotnet frameworks hence libraries targeting the newer frameworks do not need to take an explicit dependency on it. There is no need for conditional compilation just a condition on the dependency hence no additional maintaince. In fact using packages which have framework dependencies can cause issues/conflicts and increase the time to remediate CVE'S. In the case here you are by default getting a user to use a library from 7 years ago but with my changes the user if on net 6+ they immediately get the latest version in that sdk hence the performance benefit of using a library compiled for the newer TFM. As such this is a very efficient and common pattern to be followed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
