grigoni opened a new pull request, #1471: URL: https://github.com/apache/activemq/pull/1471
about StringBuffer usage, this PR splits changes per type and module use StringBuilder instead of StringBuffer: this avoids unnecessary sync use StringBuilder best practice when concatenating avoid concatenation in logging use java.nio.charset.StandardCharsets for getBytes use isEmpty() instead of ...length() > 0 use "0123456789".repeat(Math.max(0, loopSize)); instead of a loop with a SB some typos fixing see https://issues.apache.org/jira/browse/AMQ-9732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact