brusdev commented on code in PR #5822:
URL: https://github.com/apache/activemq-artemis/pull/5822#discussion_r2192483787
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java:
##########
@@ -461,7 +463,8 @@ private void doConnect() {
senders.clear();
receivers.clear();
- ClientSASLFactory saslFactory = new SaslFactory(connection,
brokerConnectConfiguration);
+ final String[] availableSaslMechanisms =
configuration.getExtraParams().containsKey(SASL_MECHANISMS_KEY) ?
protonProtocolManager.getSaslMechanisms() : null;
Review Comment:
The array `availableSaslMechanisms` seems more the list of the enabled
mechanisms than the available mechanisms, indeed in the doc you can read `The
desired SCRAM-SHA mechanisms must be enabled on the AMQP acceptor in broker.xml
by adding them to the saslMechanisms list url parameter.`
```suggestion
final String[] enabledSaslMechanisms =
configuration.getExtraParams().containsKey(SASL_MECHANISMS_KEY) ?
protonProtocolManager.getSaslMechanisms() : null;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
