clebertsuconic commented on code in PR #5934:
URL: https://github.com/apache/activemq-artemis/pull/5934#discussion_r2369415376
##########
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java:
##########
@@ -2858,16 +2858,19 @@ public synchronized void start() {
}
@Override
- public synchronized void stop() throws Exception {
+ public synchronized void stop() {
if (state == JournalState.STOPPED) {
return;
}
- flush();
+ try {
+ flush();
+ } catch (Exception e) {
+ logger.warn(e.getMessage(), e);
Review Comment:
hmmmm... I'm not really sure .. I don't see much point for this one...
logging the ongoing exception like the caller would throw should be enough on
this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
