thezbyg commented on PR #1493:
URL: https://github.com/apache/activemq/pull/1493#issuecomment-3352325553
Done, but now ConnectionView returns the same value for both `getClientId`
and `getConnectionId`:
```
public String getClientId() {
return connection.getConnectionId();
}
public String getConnectionId() {
return connection.getConnectionId();
}
```
And `connection.getConnectionId()` executes the following code in
TransportConnection class:
```
public String getConnectionId() {
List<TransportConnectionState> connectionStates =
listConnectionStates();
for (TransportConnectionState cs : connectionStates) {
if (cs.getInfo().getClientId() != null) {
return cs.getInfo().getClientId();
}
return cs.getInfo().getConnectionId().toString();
}
return null;
}
```
So it may return either `clientId` or `connectionId`.
I propose to remove connection handling changes from this pull request and
keep only changes to connector MBean and connector output in web UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
