gemmellr commented on code in PR #5945:
URL: https://github.com/apache/activemq-artemis/pull/5945#discussion_r2393899406
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpSessionTest.java:
##########
@@ -111,4 +113,64 @@ public void
testCreateSessionProducerConsumerDoesNotLeakClosable() throws Except
connection.close();
}
+ @Test
+ public void testSessionClosedOnServerEndsClientSession() throws Exception {
+ doTestSessionClosedOnServerEndsClientSession(false, false);
+ }
+
+ @Test
+ public void testSessionClosedOnServerEndsClientSessionWithFailed() throws
Exception {
+ doTestSessionClosedOnServerEndsClientSession(true, false);
+ }
+
+ @Test
+ public void testSessionClosedOnServerEndsClientSessionWithFailedAndForced()
throws Exception {
+ doTestSessionClosedOnServerEndsClientSession(true, true);
+ }
+
+ @Test
+ public void testSessionClosedOnServerEndsClientSessionForced() throws
Exception {
+ doTestSessionClosedOnServerEndsClientSession(false, true);
+ }
+
+ public void doTestSessionClosedOnServerEndsClientSession(boolean failed,
boolean forced) throws Exception {
Review Comment:
The arguments arent being used, so the same test is being repeated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
