gemmellr commented on code in PR #5958:
URL: https://github.com/apache/activemq-artemis/pull/5958#discussion_r2413777679
##########
pom.xml:
##########
@@ -165,7 +165,7 @@
<version.micrometer>1.15.4</version.micrometer>
<hamcrest.version>3.0</hamcrest.version>
<junit.version>4.13.2</junit.version>
- <junit5.version>5.13.4</junit5.version>
+ <junit6.version>6.0.0</junit6.version>
Review Comment:
Seems there are two uses. One is indeed a misuse that can be removed as the
isnt needed where its being used. I've removed that usage in
https://github.com/apache/activemq-artemis-examples/commit/fd531888654969cc95d03ef6a2b6166fc5ac16ee
However the other property reference actually is needed, since JUnit 4 is
being executed directly within the example code (to set up an ldap server etc),
which is executed via artemis maven-plugin, and so it needs the dependency
passed through the plugin definition, which for $reasons does actually need to
reference the property for the version because specifying plugin dependencies
doesnt pick up dependencyManagement.
Need to see if that can be changed, doesnt seem like it will easily (one of
the reasons other tests doing the same ldap stuff are still using junit-vintage
in the main build tree), though if not then it would be easy enough to switch
the property used by the example at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
