clebertsuconic commented on code in PR #5952:
URL: https://github.com/apache/activemq-artemis/pull/5952#discussion_r2407362613


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java:
##########
@@ -120,6 +123,9 @@ public class ServerSessionImpl implements ServerSession, 
FailureListener {
 
    private static final Logger logger = 
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
 
+   // TODO: how to configure this?
+   private int timeoutSessionClose = 5;

Review Comment:
   it was too invasive on the API.. I am adding a configuration property on 
configuration, but I don't intend to add xml for it.. I will keep it at 30 
seconds by default... ( a session should never take more than a few 
milliseconds to close )



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to