gemmellr commented on code in PR #5993:
URL: https://github.com/apache/activemq-artemis/pull/5993#discussion_r2451828451
##########
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/PagingCounterTest.java:
##########
@@ -51,8 +51,12 @@ public static Collection getParameters() {
// combinations.add(new Object[]{SNAPSHOT, ONE_FIVE, ONE_FIVE});
// combinations.add(new Object[]{ONE_FIVE, ONE_FIVE, ONE_FIVE});
- combinations.add(new Object[]{null, TWO_TWENTYTWO_ZERO, SNAPSHOT});
- combinations.add(new Object[]{null, SNAPSHOT, TWO_TWENTYTWO_ZERO});
+ if (getJavaVersion() <= 22) {
+ // 2.22.0 servers fail on JDK23+ without workarounds.
Review Comment:
Not sure which other tests you are referencing using TWO_TWENTYTWO_ZERO as
there only look to be 2 classes doing so, and I gated the related combinations
on JDK 23+ in both of them.
As above, we will still be validating those combinations using Java 17 and
21 in CI on each commit currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
