tabish121 commented on code in PR #6003:
URL: https://github.com/apache/activemq-artemis/pull/6003#discussion_r2457697237
##########
artemis-cli/src/test/java/org/apache/activemq/cli/test/ArtemisTest.java:
##########
@@ -194,6 +194,21 @@ public void testSimpleCreate() throws Exception {
Artemis.main("create", instance1.getAbsolutePath(), "--silent",
"--no-fsync", "--no-autotune");
}
+ @Test
Review Comment:
Fix looks ok. Was searching if there was a test to check that the option is
actually applied but didn't see one, would it make sense to add one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
