gtully commented on code in PR #6024:
URL: https://github.com/apache/activemq-artemis/pull/6024#discussion_r2494268576
##########
artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/LDAPLoginModule.java:
##########
@@ -71,6 +71,20 @@ public class LDAPLoginModule implements AuditLoginModule {
private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+ private static final ThreadLocal<Map<String, String>>
environmentThreadLocal = new ThreadLocal<>();
Review Comment:
I wonder if there is some way to use the login context initialise and shared
state map to pass the ssl env down to the socket factory. It may be worth a
look.
Recently I added a singleton to the kube login module, thinking that the
need for multiple instances that need to talk to different servers does not
exist. I guess with ldap (being a single centralised source of truth) the need
for multiple instances won't exist either. Currently, for ssl with ldap, the
jvm gets configured, so the tls config is currently always shared. Maybe a
singleton is sufficient.
see:
https://github.com/apache/activemq-artemis/pull/5963/files#diff-bedf8cbd7661c15968c3c7318999c811d7fd89720f71012b8e9b3af9240e856eR61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
