cshannon opened a new pull request, #1529: URL: https://github.com/apache/activemq/pull/1529
This commit updates the previous fix for preventing a read check Timer leak by the inactivity monitor when TCP connections fail This is a follow on to https://github.com/apache/activemq/pull/1119 This updated version has the following improvements: 1) The logic to cancel timers and shutdown the executor has been consolidated into one location and only done during stopping of the transport. Previously, the update could stop the task/executor during normal broker operation (see next point) 2) stopConnectCheckTask() is called under normal circumstances during initialization of a connection and the previous change caused the read task to be cancelled and the executor to be stopped, only to be immediately restarted again during the first connection creation. 3) Null checks were added to guarantee no null pointer issues when referencing tasks/timers during stop 4) Helper methods and some comments were added to simplify the code and make it easier to understand what is going on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
