gemmellr commented on code in PR #6034: URL: https://github.com/apache/activemq-artemis/pull/6034#discussion_r2503003041
########## .gitattributes: ########## @@ -0,0 +1,23 @@ +# Default to LF line endings +* text eol=lf + +# Use CRLF for Windows +*.cmd text eol=crlf + +# Don't convert or diff binary files +*.bin binary +*.eot binary +*.exe binary +*.gif binary +*.jar binary +*.jceks binary +*.jks binary +*.jpg binary +*.keystore binary +*.odg binary +*.p12 binary +*.pem binary +*.png binary +*.ttf binary +*.woff binary +*.woff2 binary Review Comment: I had started looking into this myself yesterday, and I'm actually not really keen about adding this. I dont believe I work on a single repository with a .gitattributes governing the line endings. I dont think we really need it (even to protect against odd configs like you found yourself with the other day), and I dont fancy keeping it up to date in future either. It also seems like it shouldnt be necessary for the output in future with the assembly settings changes in place, which should resolve the initial scripts being as expected in the assembly, with the other instance files line-endings being adjusted as they are created. I think just renormalizing the handful of Java and xml files for consistency is all that should be done for now, besides the assembly tweak. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
