GChuf commented on PR #6036: URL: https://github.com/apache/activemq-artemis/pull/6036#issuecomment-3505111833
> The cleanup is in there for a reason I assure you (I'm the one that put it there). Without it, it caches the build output, which is being installed as certain tests need it to be installed. Not having the cleanup can also and indeed has screwed us over in the past before it was done, more than a couple of build issues were masked due to it. Some then only getting hit at release time. I understand - most of my CICD experience comes from gitlab (and non-java projects). I don't find it hard to believe a more manual approach works better, I've worked on a couple of my own ... I did however see some outputs of jars being downloaded (on PRs not by dependabot), even though they should be cached. Example: https://github.com/apache/activemq-artemis/actions/runs/19174094055/job/54814185898 Well, at least this doesn't reach the 100k lines which happened after I changed the caching strategy :) Even though it's not extensive ... some bandwidth can be saved. About the T1C, I think i was looking at the wrong data before. But again as mentioned, it's the tests that take longer, and combined with the scrambled output I also don't think it's worth it. You mention certain tests needing "install" - I'll have to take a closer look at that, but I'm just bruteforcing through all the options and it seems the test have passed with "mvn verify" as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
