mattrpav commented on code in PR #1534:
URL: https://github.com/apache/activemq/pull/1534#discussion_r2528689394
##########
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/AnnotatedMBean.java:
##########
@@ -205,8 +204,7 @@ public Object invoke(String s, Object[] objects, String[]
strings) throws MBeanE
objects = (objects == null) ? new Object[]{} : objects;
JMXAuditLogEntry entry = null;
if (audit != OFF) {
- // [AMQ-9563] TODO: JDK 21 use Subject.current() instead
- Subject subject =
Subject.getSubject(AccessController.getContext());
+ Subject subject = SecurityManagerShim.currentSubject();
Review Comment:
Do we really need the shim? I'm wondering if we just ship two AnnotatedBean
classes using MR jar and switch the JAAS API implementation when getting the
Subject.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
