brusdev commented on code in PR #6081:
URL: https://github.com/apache/activemq-artemis/pull/6081#discussion_r2538324126
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java:
##########
@@ -394,11 +393,11 @@ public String getRemoteAddress() {
@Override
public final String getLocalAddress() {
- SocketAddress address = channel.localAddress();
+ String address = SocketAddressUtil.toString(channel.localAddress());
if (address == null) {
return null;
}
- return "tcp://" + IPV6Util.encloseHost(address.toString());
Review Comment:
This change could affect the users who filter by localAddress when listing
connections, consumers, producers and sessions. Could you add a note for the
next release in the versions.adoc file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
