cshannon commented on PR #1551: URL: https://github.com/apache/activemq/pull/1551#issuecomment-3596784873
After looking more into this I think it's fine to merge. It's only a single message being added and the memory pressure should not be so high that one message causes an OOM. There are plenty of spots in the broker where we are incrementing/decrementing memory counters and it isn't exact because messages are still in memory and being processed. In fact, queues allow paging in up to 110% of the memory setting to allow dispatch and unblocking. The memory usage tracking is always just an estimate in general and I think the fix makes sense and unlikely to cause any issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
