jeanouii opened a new pull request, #1555: URL: https://github.com/apache/activemq/pull/1555
This is taking about an hour to run. The @Before code is running every single time for all the test scenario of the class. I'm questioning what the benefit of the @Before peace of code. If it's an actual test, I'd pull it into its own @Test method. But for now, it's burning a lot of time because it does a lot of IO and the CI is slow for IO. Moreover, the directory used in the sendMessage call of the @Before portion is the default one, because the broker is lazily created after using the VM Transport, whereas all the other tests are actually using a different directory. Locally on my Mac M1 it runs on 16 min and after the removal, it runs in 2'30. If everyone is happy with it, I can create a JIRA and rename this PR and update the commit message -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
