jbertram commented on code in PR #6097:
URL: https://github.com/apache/activemq-artemis/pull/6097#discussion_r2585831426


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/management/ManagementService.java:
##########
@@ -159,4 +162,7 @@ void registerBroadcastGroup(BroadcastGroup broadcastGroup,
 
    Object invokeOperation(String resourceName, String operation, Object[] 
params, SecurityAuth auth) throws Exception;
 
+   List<QueueControl> getQueueControls(Predicate<QueueControl> predicate);

Review Comment:
   Consider adding:
   ```java
   List<QueueControl> getQueueControls();
   ```
   That way folks wouldn't have to pass `null` to get all the controls. Passing 
`null` isn't intuitive.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to