jeanouii commented on code in PR #1556:
URL: https://github.com/apache/activemq/pull/1556#discussion_r2603398183
##########
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/ConnectorView.java:
##########
@@ -151,4 +153,82 @@ public boolean isAutoStart() {
public boolean isStarted() {
return this.connector.isStarted();
}
+
+ @Override
+ public String getConnectURI() {
+ URI tmpConnectUri = null;
+ try {
+ tmpConnectUri = this.connector.getConnectUri();
Review Comment:
I find it more readable to do a return this.connector.getConnectUri() and
return null in the catch block.
##########
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/ConnectorView.java:
##########
@@ -151,4 +153,82 @@ public boolean isAutoStart() {
public boolean isStarted() {
return this.connector.isStarted();
}
+
+ @Override
+ public String getConnectURI() {
+ URI tmpConnectUri = null;
+ try {
+ tmpConnectUri = this.connector.getConnectUri();
+ } catch (Exception e) {}
+ return (tmpConnectUri != null ? tmpConnectUri.toString() : null);
+ }
+
+ @Override
+ public String getPublishableConnectURI() {
+ URI publishableConnectURI = null;
+ try {
+ publishableConnectURI = this.connector.getPublishableConnectURI();
Review Comment:
Same as previous
##########
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/ConnectorView.java:
##########
@@ -151,4 +153,82 @@ public boolean isAutoStart() {
public boolean isStarted() {
return this.connector.isStarted();
}
+
+ @Override
+ public String getConnectURI() {
+ URI tmpConnectUri = null;
+ try {
+ tmpConnectUri = this.connector.getConnectUri();
+ } catch (Exception e) {}
+ return (tmpConnectUri != null ? tmpConnectUri.toString() : null);
+ }
+
+ @Override
+ public String getPublishableConnectURI() {
+ URI publishableConnectURI = null;
+ try {
+ publishableConnectURI = this.connector.getPublishableConnectURI();
+ } catch (Exception e) {}
+
+ return (publishableConnectURI != null ?
publishableConnectURI.toString() : null);
+ }
+
+ @Override
+ public String getBrokerInfoString() {
+ var tmpBrokerInfo = this.connector.getBrokerInfo();
+ return (tmpBrokerInfo != null ? tmpBrokerInfo.toString() : null);
Review Comment:
There is a getBrokerInfo() method already available
##########
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/ConnectorView.java:
##########
@@ -151,4 +153,82 @@ public boolean isAutoStart() {
public boolean isStarted() {
return this.connector.isStarted();
}
+
+ @Override
+ public String getConnectURI() {
+ URI tmpConnectUri = null;
+ try {
+ tmpConnectUri = this.connector.getConnectUri();
+ } catch (Exception e) {}
+ return (tmpConnectUri != null ? tmpConnectUri.toString() : null);
+ }
+
+ @Override
+ public String getPublishableConnectURI() {
+ URI publishableConnectURI = null;
+ try {
+ publishableConnectURI = this.connector.getPublishableConnectURI();
+ } catch (Exception e) {}
+
+ return (publishableConnectURI != null ?
publishableConnectURI.toString() : null);
+ }
+
+ @Override
+ public String getBrokerInfoString() {
+ var tmpBrokerInfo = this.connector.getBrokerInfo();
+ return (tmpBrokerInfo != null ? tmpBrokerInfo.toString() : null);
Review Comment:
if getBrokerInfo() can really return null, you probably could add a null
check above in other methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
