jeanouii commented on code in PR #1497:
URL: https://github.com/apache/activemq/pull/1497#discussion_r2614199622


##########
activemq-kahadb-store/src/test/java/org/apache/activemq/store/kahadb/JournalCorruptionEofIndexRecoveryTest.java:
##########
@@ -63,12 +63,13 @@
 import org.apache.logging.log4j.core.layout.MessageLayout;
 import org.junit.After;
 import org.junit.Before;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.slf4j.event.LoggingEvent;
 
-
+@Ignore("Temporary to test GitHub Action")

Review Comment:
   This one should now be stable - whenever the other PRs are merged, we can 
rebase and put it back



##########
activemq-kahadb-store/pom.xml:
##########
@@ -30,6 +30,10 @@
   <name>ActiveMQ :: KahaDB Store</name>
   <description>The ActiveMQ KahaDB Store Implementation</description>
 
+  <properties>
+    <surefire.argLine>-Xmx512M</surefire.argLine>

Review Comment:
   This should not be required when we merge all other PRs. The OOME should not 
trigger anymore.



##########
pom.xml:
##########
@@ -968,13 +968,12 @@
             <redirectTestOutputToFile>true</redirectTestOutputToFile>
             <forkCount>1</forkCount>
             <reuseForks>true</reuseForks>
-            <argLine>-enableassertions</argLine>
             <failIfNoTests>false</failIfNoTests>
             <systemPropertyVariables>
                 <java.awt.headless>true</java.awt.headless>
                 
<org.apache.activemq.kahaDB.files.skipMetadataUpdate>true</org.apache.activemq.kahaDB.files.skipMetadataUpdate>
             </systemPropertyVariables>
-            <argLine>-Xmx512m</argLine>
+            <argLine>-enableassertions -Xmx1G</argLine>

Review Comment:
   Same here for the memory increase.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to