jeanouii commented on code in PR #1621:
URL: https://github.com/apache/activemq/pull/1621#discussion_r2709537322
##########
activemq-mqtt/src/test/java/org/apache/activemq/transport/mqtt/MQTTProtocolConverterTest.java:
##########
@@ -129,7 +129,7 @@ public void run() {
executorService.awaitTermination(10, TimeUnit.SECONDS);
ArgumentCaptor<RemoveInfo> removeInfo =
ArgumentCaptor.forClass(RemoveInfo.class);
- Mockito.verify(transport,
times(4)).sendToActiveMQ(removeInfo.capture());
+ Mockito.verify(transport,
times(1)).sendToActiveMQ(removeInfo.capture());
Review Comment:
It's not about speeding the test, it's about the converter implementation
which is cristal clear. I think it's more Mockito or the attachment of the
agent failed sometimes.
I updated Mockito and used a regular JavaAgent as opposed to attaching the
agent to self. Might have helped revealing the issue especially it was
returning all the calls as opposed to the calls of RemoveInfo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
