jeanouii commented on code in PR #1622:
URL: https://github.com/apache/activemq/pull/1622#discussion_r2716477888
##########
activemq-ra/src/test/java/org/apache/activemq/ra/ActiveMQConnectionFactoryTest.java:
##########
@@ -137,7 +137,7 @@ public void testXAResourceReconnect() throws Exception {
try {
final TransportConnector transportConnector =
brokerService.getTransportConnectors().get(0);
- String failoverUrl =
String.format("failover:(%s)?maxReconnectAttempts=10&initialReconnectDelay=100",
transportConnector.getConnectUri());
+ String failoverUrl =
String.format("failover:(%s)?startupMaxReconnectAttempts=10&maxReconnectAttempts=2&initialReconnectDelay=100&timeout=2000",
transportConnector.getConnectUri());
Review Comment:
Yes, 2 things here
- maxReconnectAttempts isn't used the first time, so we may well timeout
even without starting
- Adding startupMaxReconnectAttempt make it fails faster it has to
- timeout=2000 is another way to approach it yes. Increasing to 120s would
work, but does not go in the direction we are trying to go (decrease build time
if possible)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
