pradeep85841 commented on code in PR #1631: URL: https://github.com/apache/activemq/pull/1631#discussion_r2727509823
########## activemq-unit-tests/src/test/java/org/apache/activemq/VmTransportBrokerRestartTest.java: ########## @@ -0,0 +1,77 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.activemq; + +import jakarta.jms.TextMessage; +import org.apache.activemq.broker.BrokerService; +import org.junit.After; + + +public class VmTransportBrokerRestartTest extends EmbeddedBrokerTestSupport { Review Comment: Thanks for the feedback! I’ve added broker.waitUntilStarted() after restarting the broker to avoid any race conditions. The test was added based on issues observed around VM transport behavior after broker restarts, and is intended to guard against regressions in that area. I’ve also added @category(ParallelTest.class) since the test uses an isolated embedded broker and should be safe to run in parallel. I kept JmsTemplate for consistency with existing tests, but agree that moving to plain JMS would make sense in a follow-up if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
