mattrpav commented on code in PR #1661:
URL: https://github.com/apache/activemq/pull/1661#discussion_r2833609362
##########
activemq-broker/src/test/java/org/apache/activemq/broker/jmx/ManagementContextSslTest.java:
##########
@@ -192,6 +195,9 @@ public void testConnectorStartsWithSsl() throws Exception {
SSLContext.setDefault(testSslContext);
System.setProperty("javax.net.ssl.trustStore",
keystoreFile.toString());
System.setProperty("javax.net.ssl.trustStorePassword",
KEYSTORE_PASSWORD);
+ // Force RMI stubs to advertise "localhost" so SSL hostname
verification
+ // matches the certificate SAN (dns:localhost) instead of the
machine's IP.
+ System.setProperty("java.rmi.server.hostname", "localhost");
Review Comment:
This can be localized into the RMIServer environment map vs only supporting
it via the System Property
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
