jbonofre commented on PR #1728: URL: https://github.com/apache/activemq/pull/1728#issuecomment-4018569349
For the discussion/feedback, we can use GitHub Discussions (linked to the PR), or (as discussed in the past on the dev@ mailing list), we can also create md files for the website. I took a quick look on this one and I have some comments: 1. The PR looks ~90% compliant to the spec (I did a new read on the spec). To my understanding, the main "issue" is about the `recover()` restriction check. 2. I'm completely fine with the "not truly async" aspect as soon as it's documented. Ok, it doesn't deliver the performance benefit the spec suggests, but it's still spec compliant. I think the PR is solid as a first implementation, we can improve it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
