pradeep85841 commented on PR #1736: URL: https://github.com/apache/activemq/pull/1736#issuecomment-4040190896
Thank you for the detailed review and suggestions. I agree with your points. I will update the ActiveMQConnectionFactory as well to set the default to false. This ensures the setting correctly propagates to all connections as intended for Jakarta 3.1 compliance. And will refactor the unit tests to use try-with-resources for better connection management. I will also ensure the embedded broker is explicitly stopped to avoid any flakiness in the CI. I am working on these changes and will push the updated code shortly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
