jeanouii commented on code in PR #1757:
URL: https://github.com/apache/activemq/pull/1757#discussion_r2924070859
##########
assembly/pom.xml:
##########
@@ -703,5 +703,105 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>docker</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>io.fabric8</groupId>
+ <artifactId>docker-maven-plugin</artifactId>
+ <version>0.45.1</version>
+ <configuration>
+ <images>
+ <image>
+ <name>apache/activemq:${project.version}</name>
+ <build>
+
<dockerFile>${project.basedir}/src/docker/Dockerfile</dockerFile>
+ <contextDir>${project.basedir}/src/docker</contextDir>
+ <args>
+
<activemq_dist>_TMP_/apache-activemq.tar.gz</activemq_dist>
+ </args>
+ <assembly>
+ <name>_TMP_</name>
+ <inline>
+ <files>
+ <file>
+
<source>${project.build.directory}/apache-activemq-${project.version}-bin.tar.gz</source>
+ <destName>apache-activemq.tar.gz</destName>
+ <outputDirectory>.</outputDirectory>
+ </file>
+ </files>
+ </inline>
+ </assembly>
+ </build>
+ </image>
+ </images>
+ </configuration>
+ <executions>
+ <execution>
+ <id>docker-build</id>
+ <phase>package</phase>
+ <goals>
+ <goal>build</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+ <profile>
+ <id>docker-deploy</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>io.fabric8</groupId>
+ <artifactId>docker-maven-plugin</artifactId>
+ <version>0.45.1</version>
Review Comment:
Also do we need goal -> push?
The docker images are built locally but never pushed, right?
##########
assembly/pom.xml:
##########
@@ -703,5 +703,105 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>docker</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>io.fabric8</groupId>
+ <artifactId>docker-maven-plugin</artifactId>
+ <version>0.45.1</version>
+ <configuration>
+ <images>
+ <image>
+ <name>apache/activemq:${project.version}</name>
+ <build>
+
<dockerFile>${project.basedir}/src/docker/Dockerfile</dockerFile>
+ <contextDir>${project.basedir}/src/docker</contextDir>
+ <args>
+
<activemq_dist>_TMP_/apache-activemq.tar.gz</activemq_dist>
+ </args>
+ <assembly>
+ <name>_TMP_</name>
+ <inline>
+ <files>
+ <file>
+
<source>${project.build.directory}/apache-activemq-${project.version}-bin.tar.gz</source>
+ <destName>apache-activemq.tar.gz</destName>
+ <outputDirectory>.</outputDirectory>
+ </file>
+ </files>
+ </inline>
+ </assembly>
+ </build>
+ </image>
+ </images>
+ </configuration>
+ <executions>
+ <execution>
+ <id>docker-build</id>
+ <phase>package</phase>
+ <goals>
+ <goal>build</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+ <profile>
+ <id>docker-deploy</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>io.fabric8</groupId>
+ <artifactId>docker-maven-plugin</artifactId>
+ <version>0.45.1</version>
Review Comment:
We use the version twice. Not a blocker, but would be better to extract it
and reuse it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
