jbonofre commented on code in PR #1832:
URL: https://github.com/apache/activemq/pull/1832#discussion_r2989676777
##########
activemq-unit-tests/src/test/java/org/apache/activemq/usecases/AdvisoryViaNetworkTest.java:
##########
@@ -311,6 +311,7 @@ public void testAdvisoryForwardingDuplexNC() throws
Exception {
networkBridge.setDuplex(true);
startAllBrokers();
verifyPeerBrokerInfo(brokers.get("A"), 1);
+ verifyPeerBrokerInfo(brokers.get("B"), 1);
Review Comment:
Good catch.
In a duplex connector, Broker A initiates the connection but Broker B must
also establish a sub-bridge for the reverse path. The existing code only waited
for A's peer info, creating a race where advisories sent before B's bridge was
ready would be silently dropped (fire-and-forget semantics).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
