mattrpav commented on code in PR #1829:
URL: https://github.com/apache/activemq/pull/1829#discussion_r2995723200


##########
activemq-broker/src/main/java/org/apache/activemq/network/MulticastNetworkConnector.java:
##########
@@ -77,6 +77,11 @@ public void setRemoteTransport(Transport remoteTransport) {
         this.remoteTransport = remoteTransport;
     }
 
+    @Override
+    public URI getUri() {
+        return remoteURI;

Review Comment:
   I think it'd make more sense to make MulticastNetworkConnector have a 
'getUri()' method instead.
   
   I'm pretty against doing any field name mapping at the admin view b/c it is 
miscommunicating to users 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to