gurpartap3697 commented on code in PR #1862:
URL: https://github.com/apache/activemq/pull/1862#discussion_r3011693901


##########
activemq-unit-tests/src/test/java/org/apache/activemq/store/jdbc/XACompletionTest.java:
##########
@@ -249,6 +249,7 @@ public void testStatsAndBrowseAfterAckPreparedRolledback() 
throws Exception {
         resource.recover(XAResource.TMSTARTRSCAN);
         resource.recover(XAResource.TMNOFLAGS);
 
+        Wait.waitFor(() -> proxy.getInFlightCount() == 0L && 
proxy.cursorSize() == 0);

Review Comment:
   Good point — thanks for calling that out.
   
   I initially assumed that inFlightCount == 0 would imply the queue state 
(including queueSize) had fully settled. I've updated the wait condition to 
include getQueueSize()



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to