cshannon commented on PR #1865: URL: https://github.com/apache/activemq/pull/1865#issuecomment-4178836374
So I am not saying there is not an issue here, but I'm trying to figure out what I am missing because the reconnect logic still seems to be fired even without this fix because the TimeoutException is still being passed along to bridge failed. Maybe there is a race condition. Here is what I am seeing when I run the test case and step through things without the fix: 1. EOFException does happen first and is caught here and [aborts](https://github.com/apache/activemq/blob/27c17441d681e2b325e5e0700220a7b0d302e780/activemq-broker/src/main/java/org/apache/activemq/network/DemandForwardingBridgeSupport.java#L231) as noted 2. However, after that happens the call to collectBrokerInfos() is called [here](https://github.com/apache/activemq/blob/27c17441d681e2b325e5e0700220a7b0d302e780/activemq-broker/src/main/java/org/apache/activemq/network/DemandForwardingBridgeSupport.java#L370). 3. collectBrokerInfos() triggers a timeout exception and is caught [here](https://github.com/apache/activemq/blob/27c17441d681e2b325e5e0700220a7b0d302e780/activemq-broker/src/main/java/org/apache/activemq/network/DemandForwardingBridgeSupport.java#L398) 4. bridgeFailedError(timeoutException) is called [here](https://github.com/apache/activemq/blob/27c17441d681e2b325e5e0700220a7b0d302e780/activemq-broker/src/main/java/org/apache/activemq/network/DemandForwardingBridgeSupport.java#L663) which passes in that timeout exception and called bridgeFailed() on the listener 5. discoveryServiceAgent.sericeFailed(event) is invoked [here](https://github.com/apache/activemq/blob/27c17441d681e2b325e5e0700220a7b0d302e780/activemq-broker/src/main/java/org/apache/activemq/network/DiscoveryNetworkConnector.java#L254) which in turn kicks off the reconnect logic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
