jbonofre commented on code in PR #1910:
URL: https://github.com/apache/activemq/pull/1910#discussion_r3074169889
##########
activemq-spring/src/main/java/org/apache/activemq/xbean/XBeanBrokerFactory.java:
##########
@@ -17,14 +17,23 @@
package org.apache.activemq.xbean;
import java.beans.PropertyEditorManager;
+import java.io.IOException;
import java.net.MalformedURLException;
import java.net.URI;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Set;
+import java.util.stream.Collectors;
import org.apache.activemq.broker.BrokerContextAware;
import org.apache.activemq.broker.BrokerFactoryHandler;
import org.apache.activemq.broker.BrokerService;
import org.apache.activemq.spring.SpringBrokerContext;
import org.apache.activemq.spring.Utils;
+import org.apache.activemq.transport.stomp.FrameTranslator;
Review Comment:
It seems these imports are not actually used in the factory.
Maybe coming from previous dev ?
##########
activemq-spring/src/main/java/org/apache/activemq/xbean/XBeanBrokerFactory.java:
##########
@@ -42,13 +51,33 @@
*
*/
public class XBeanBrokerFactory implements BrokerFactoryHandler {
- private static final transient Logger LOG =
LoggerFactory.getLogger(XBeanBrokerFactory.class);
+ private static final Logger LOG =
LoggerFactory.getLogger(XBeanBrokerFactory.class);
+
+ public static final String XBEAN_BROKER_FACTORY_PROTOCOLS_PROP =
+ "org.apache.activemq.xbean.XBEAN_BROKER_FACTORY_PROTOCOLS";
+ public static final String DEFAULT_ALLOWED_PROTOCOLS =
+ String.join(",", Set.of(Utils.FILE_PROTOCOL,
Utils.CLASSPATH_PROTOCOL));
Review Comment:
There's no guarantee of order here: it could be `file,classpath` or
`classpath,file`.
Why not just using a simple `Utils.FILE_PROTOCOL + "," +
Utils.CLASSPATH_PROTOCOL`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
