cshannon commented on code in PR #1918:
URL: https://github.com/apache/activemq/pull/1918#discussion_r3079552674


##########
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/BrokerView.java:
##########
@@ -44,6 +44,8 @@ public class BrokerView implements BrokerViewMBean {
 
     private static final Logger LOG = 
LoggerFactory.getLogger(BrokerView.class);
 
+    private static final Set<String> DENIED_TRANSPORT_SCHEMES = Set.of("vm", 
"http");

Review Comment:
   Surprisingly (or maybe not given the age) there is no https discovery 
protocol, the broker only supports http for that.
   
   There is http and https transports but those are not the same as the http 
discovery.
   
   Here is the location for the http/https transport references: 
https://github.com/apache/activemq/tree/main/activemq-http/src/main/resources/META-INF/services/org/apache/activemq/transport
   
   And here is the location for http discovery: 
https://github.com/apache/activemq/tree/main/activemq-http/src/main/resources/META-INF/services/org/apache/activemq/transport/discoveryagent



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to