mattrpav commented on PR #1921: URL: https://github.com/apache/activemq/pull/1921#issuecomment-4244487608
I'm not sure there is really a problem with having the RuntimeConfigPlugin running while the broker is active or inactive. The Broker does not have a lifecycle hook to indicate when the persistent store is not available (aka 'slave'). So this change only solves for the 'first time' becoming primary/master. If the broker flips back to failover/slave, the RuntimeConfigPlugin will still be active and processing configuration changes. Since the plugin can process transportConnectors, I can see a scenario where an original set of transport connectors come online, but the user has already removed (or changed) via config, but the plugin hasn't processed yet so ports come online that were not intended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
